Skip to content

Fix incorrect error descriptions#46

Open
roanutil wants to merge 3 commits intomainfrom
fix-incorrect-error-descriptions
Open

Fix incorrect error descriptions#46
roanutil wants to merge 3 commits intomainfrom
fix-incorrect-error-descriptions

Conversation

@roanutil
Copy link
Owner

  • Add static errorDescription requirement to FetchableUnmanagedModel
    • This enables error descriptions in scenarios where there is no instance of self like when a read fails
  • Use errorDescription instead of Self.self where possible
  • Add default conformance for unamangeId error description when UnmanagedId conforms to CustomStringConvertible
    • I've tested this in Align to verify that the default implementation can be overridden

…edId conforms to CustomStringConvertible

fix-incorrect-error-descriptions
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.33%. Comparing base (47de46c) to head (b91ae75).

Files with missing lines Patch % Lines
.../CoreDataRepository/IdentifiedUnmanagedModel.swift 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   85.30%   85.33%   +0.03%     
==========================================
  Files          69       69              
  Lines        8528     8532       +4     
==========================================
+ Hits         7275     7281       +6     
+ Misses       1253     1251       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants